[6.2][SE-0461] Replace @execution(...) with @concurrent and nonisolated(nonsending)
#80807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
hborla
approved these changes
Apr 14, 2025
|
@swift-ci please clean test |
|
swiftlang/swift-syntax#3055 |
|
swiftlang/swift-syntax#3055 |
xedin
force-pushed
the
se-0461-renamings-6.2
branch
from
29a4d14 to
b9444b6
Compare
|
swiftlang/swift-syntax#3055 |
|
swiftlang/swift-syntax#3055 |
…ute` or `StringRef` It has been decided to split the attribute into `@concurrent` and `nonisolated(nonsending`. Adjusting diagnostics to accept the attribute makes the transition easier.
…(concurrent)` spelling
…execution(caller)`
xedin
force-pushed
the
se-0461-renamings-6.2
branch
from
b9444b6 to
19f8464
Compare
|
swiftlang/swift-syntax#3055 |
|
swiftlang/swift-syntax#3055 |
|
swiftlang/swift-syntax#3055 |
Complete the transition from `@execution` to `@concurrent` and `nonisolated(nonsending)`
SE-0461 has been accepted and `@concurrent` and `nonisolated(nonsending)` can be make generally available now.
Accept it only if it's spelled `nonisolated(nonsending)` and nothing else to minimize any possible source compatibility impact.
…ure to match `@execution` attribute split
…ed(nonsending)` in swift interface files
(cherry picked from commit 4b1695b)
xedin
force-pushed
the
se-0461-renamings-6.2
branch
from
19f8464 to
c8c7eef
Compare
|
swiftlang/swift-syntax#3055 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #80668
Explanation:
Adjust implementation for SE-0461 to match final/accepted attribute forms.
@concurrentdeclaration and type attributes to replace@execution(concurrent)nonsendingmodifier tononisolateddeclaration modifiernonisolated(nonsending)in type and expression contexts (modeled viaCallerIsolatedTypeRepr)@execution(caller)withnonisolated(nonsending)modifier@executionattribute throughout the codebaseExecutionAttributeexperimental flagMain Branch PR: [SE-0461] Replace
@execution(...)with@concurrentandnonisolated(nonsending)#80668Risk: Low (replaces existing
@executionattribute, which was guarded by an experimental feature flag, with two new attributes. The only risk here is related tononisolatedkeyword expansion to acceptnonsendingmodifier, this could cause a source break if there exists a function which such a name an an argument with namenonsending, which seems like a very low probability).Reviewed By: @hamishknight @AnthonyLatsis @tshortli
Testing: Added new tests to the test suite.